Skip to content

Add Wind Turbine bindings#34

Merged
nhatcher-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom
nhatcher-frequenz:wind-turbines
Dec 12, 2025
Merged

Add Wind Turbine bindings#34
nhatcher-frequenz merged 2 commits intofrequenz-floss:v0.x.xfrom
nhatcher-frequenz:wind-turbines

Conversation

@nhatcher-frequenz
Copy link
Contributor

Fixes #33

Copilot AI review requested due to automatic review settings December 11, 2025 11:19
@nhatcher-frequenz nhatcher-frequenz requested a review from a team as a code owner December 11, 2025 11:19
@nhatcher-frequenz nhatcher-frequenz self-assigned this Dec 11, 2025
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) labels Dec 11, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Wind Turbine component bindings to the microgrid component graph library, addressing issue #33. The implementation follows the established patterns for other component types (EV chargers, CHPs, etc.) and includes formula generation capabilities for wind turbines.

Key Changes:

  • Implements wind_turbine_formula() method for generating wind turbine power formulas
  • Adds Wind Turbine category recognition in the Rust component category mapping
  • Updates project version from 0.2.0 to 0.3.0 with corresponding dependency updates

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_microgrid_component_graph.py Adds comprehensive test coverage for wind turbine graph creation, component retrieval, formula generation, and topology validation
src/graph.rs Implements the wind_turbine_formula method with optional component ID filtering, consistent with existing formula methods
src/category.rs Adds WindTurbine class binding and category mapping to recognize wind turbine components from Python
python/frequenz/microgrid_component_graph/init.pyi Adds type stub documentation for the wind_turbine_formula method with detailed parameter descriptions
RELEASE_NOTES.md Documents the addition of wind turbine bindings as a new feature
Cargo.toml Updates package version to 0.3.0 and bumps dependency to matching version
Cargo.lock Updates lock file to reflect new version and dependency checksums

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nhatcher-frequenz nhatcher-frequenz force-pushed the wind-turbines branch 2 times, most recently from b51524a to c22c80e Compare December 11, 2025 11:35
Fixes frequenz-floss#33

Signed-off-by: Nicolás Hatcher <nicolas.hatcher@frequenz.com>
@shsms
Copy link
Collaborator

shsms commented Dec 11, 2025

Unfortunately the tests only cover the microgrid api cases. But this can be used with the assets client as well:

This PR no longer breaks the microgrid usecases, but could you do the assets client as well, before we take this in? frequenz-floss/frequenz-client-assets-python#58

Signed-off-by: Nicolás Hatcher <nicolas.hatcher@frequenz.com>
@nhatcher-frequenz nhatcher-frequenz added this pull request to the merge queue Dec 12, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 22eb3c3 Dec 12, 2025
5 checks passed
@nhatcher-frequenz nhatcher-frequenz deleted the wind-turbines branch December 12, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support wind formulas

3 participants