Gross patch for tailscale.py #1263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some weird behavior (frenck#1262) where the client expects a dict and the API is now (?) returning a list, as well as mismatched property casing (snake `hair_pinning` vs. camel `hairPinning`). This is not the "correct" way to fix it, but it will at least get things working again.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some weird behavior (#1262) where the client expects a dict and the API is now (?) returning a list, as well as mismatched property casing (snake
hair_pinningvs. camelhairPinning).This is not the "correct" way to fix it, but it will at least get things working again.
Proposed Changes
Not actually proposing these changes, but demonstrating the problem and a workaround for anyone who needs this temporarily patched.
Related Issues