Skip to content

fix: succeed dryrun on missing previous version #2612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: succeed dryrun on missing previous version #2612

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e41572c
fix: succeed dryrun on missing previous version
Aug 26, 2025
33018ee
Merge branch 'main' into fix-dryrun-again
Aug 26, 2025
b814fd7
Merge branch 'main' into fix-dryrun-again
Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cli/pkg/cmd/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ func HandleReleaseDiff(kpClientParams kutil.RequestParameters, args kutil.Authen
log.Printf("error on getting manifests, error: %v", err)
Copy link
Copy Markdown
Contributor

@sven-urbanski-freiheit-com sven-urbanski-freiheit-com Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't we still get an error when calling getManifests here?

Copy link
Copy Markdown
Author

@ghost ghost Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, GetManifests now returns an empty string on a 404 getting an manifest here.

return ReturnCodeFailure
}
if len(body) == 0 {
fmt.Printf("No previous version.\n")
return ReturnCodeSuccess // no previous version, allow this to pass
}

var resp = &GetManifestsResponse{
Manifests: nil,
Expand Down
Loading