Skip to content

Add in a part_svc.comment, with ability to edit/view #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jayceh wants to merge 2 commits into
base: FREESIDE_4_BRANCH
Choose a base branch
from
Open

Add in a part_svc.comment, with ability to edit/view #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3534b1
Add in a part_svc.comment, with ability to edit/view
Jayceh Aug 28, 2015
aa04c99
Fix nullable error
Jayceh Aug 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FS/FS/Schema.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3580,6 +3580,7 @@ sub tables_hashref {
'columns' => [
'svcpart', 'serial', '', '', '', '',
'svc', 'varchar', '', $char_d, '', '',
'comment', 'varchar', 'NULL', $char_d, '', '',
'svcdb', 'varchar', '', $char_d, '', '',
'disabled', 'char', 'NULL', 1, '', '',
'preserve', 'char', 'NULL', 1, '', '',
Expand Down
3 changes: 3 additions & 0 deletions FS/FS/part_svc.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ FS::Record. The following fields are currently supported:

=item svc - text name of this service definition

=item comment - text comment of this service definition

=item svcdb - table used for this service. See L<FS::svc_acct>,
L<FS::svc_domain>, and L<FS::svc_forward>, among others.

Expand Down Expand Up @@ -414,6 +416,7 @@ sub check {
$error=
$self->ut_numbern('svcpart')
|| $self->ut_text('svc')
|| $self->ut_textn('comment')
|| $self->ut_alpha('svcdb')
|| $self->ut_flag('disabled')
|| $self->ut_flag('preserve')
Expand Down
2 changes: 1 addition & 1 deletion httemplate/edit/elements/part_svc_column.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@
<& /elements/progress-init.html,
$svcdb, #form name
[ # form fields to send
qw(svc svcpart classnum selfservice_access disabled preserve exportnum),
qw(svc svcpart classnum selfservice_access disabled preserve exportnum comment),
@fields
],
'process/part_svc.cgi', # target
Expand Down
7 changes: 6 additions & 1 deletion httemplate/edit/part_svc.cgi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ window.onload = function() {
<TD><INPUT TYPE="text" NAME="svc" VALUE="<% $hashref->{svc} %>"></TD>
<TR>

<TR>
<TD ALIGN="right">Service Comment</TD>
<TD><INPUT TYPE="text" NAME="comment" VALUE="<% $hashref->{comment} %>"></TD>
<TR>

<& /elements/tr-select-part_svc_class.html, curr_value=>$hashref->{classnum} &>

<TR>
Expand Down Expand Up @@ -244,7 +249,7 @@ my $widget = new HTML::Widgets::SelectLayers(
#'form_action' => 'process/part_svc.cgi',
'form_action' => 'part_svc.cgi', #self
'form_elements' => [qw( svc svcpart classnum selfservice_access
disabled preserve
disabled preserve comment
)],
'html_between' => $help,
'layer_callback' => sub {
Expand Down