This repository was archived by the owner on Oct 11, 2018. It is now read-only.
Open
Conversation
Contributor
thibaultzanini
left a comment
thibaultzanini
left a comment
There was a problem hiding this comment.
A little question otherwise it looks good to me.
| this._highlightedOption = this.optionsOverlayComponent.templateObjects.options.iterations[newIndex % contentLength]; | ||
|
|
||
| // scroll to element | ||
| var highlightedElement = this._highlightedOption.firstElement, |
Contributor
There was a problem hiding this comment.
That's only work if all options have the same height, it's not an issue in our case?
Contributor
Author
There was a problem hiding this comment.
but below i'm grabbing the highlightedElement.offsetTop so I don't believe the height changes will affect this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when navigating the select with arrow keys the options should scroll