Refactor mediapipe process tracked objects #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily simplify the logic in the
process_tracked_objectsfunction in the Mediapipe Holistic recorder.The prior iteration used some complicated numerical indexing that was hard for me to follow and seemed very difficult to maintain (or even verify for correctness). So I wrote a few more tests and then refactored the function to be easier to understand. Now it makes an array for each type of landmark (pose, hands, face) and then concatenates the arrays in the proper order. I also added a comment to not change that order. The prior version was dependent on receiving the tracked objects in the correct order.