Jon/development #66
Open
Jon/development #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Running |
Member
Author
|
Tweaked things so that the QT GUI runs and records and whatnot. You can run that raw skellycam via This is the current best method we have for recording videos |
philipqueen
reviewed
Jan 22, 2025
| # framerate_tracker = framerate_tracker, | ||
| # camera_id=camera_id) | ||
| tik2 = time.perf_counter_ns() | ||
| multi_frame_escape_shm.put_multi_frame_payload(mf_payload) |
Contributor
There was a problem hiding this comment.
I'm noticing a lot of the work here is pulling from shm and putting into different shm.
Is it possible to use 1 shared memory instance instead of two and prevent creating an extra process? Or does the orchestration and frame rate tracking have to happen here?
Contributor
There was a problem hiding this comment.
Also possible I'm not fully grokking how the frame escape shared memory is interacting with the websocket further on
# Conflicts: # skellycam-ui/src/components/camera-config-panel/CameraConfigPanel.tsx # skellycam-ui/src/components/camera-config-tree-view/CameraConfigTreeViewHeader.tsx # skellycam-ui/src/components/camera-views/CameraView.tsx # skellycam-ui/src/components/camera-views/CameraViewsGrid.tsx # skellycam-ui/src/components/framerate-viewer/FrameRateViewer.tsx # skellycam-ui/src/components/ui-components/BottomPanelContent.tsx # skellycam-ui/src/components/ui-components/LeftSidePanelContent.tsx # skellycam-ui/src/pages/CamerasPage.tsx # skellycam-ui/src/pages/WelcomePage.tsx # skellycam-ui/src/services/server/ServerContextProvider.tsx # skellycam-ui/src/services/server/server-helpers/frame-processor/binary-frame-parser.ts # skellycam-ui/src/services/server/server-helpers/server-urls.ts # skellycam-ui/src/store/slices/cameras/cameras-slice.ts # skellycam-ui/src/store/slices/cameras/cameras-thunks.ts # skellycam-ui/src/store/slices/cameras/cameras-types.ts # skellycam-ui/src/store/slices/framerate/framerate-selectors.ts # skellycam-ui/src/store/slices/framerate/framerate-slice.ts # skellycam/__main__.py # skellycam/api/http/cameras/camera_router.py # skellycam/api/middleware/add_middleware.py # skellycam/api/websocket/websocket_server.py # skellycam/app.py # skellycam/core/camera/camera_manager.py # skellycam/core/camera/camera_worker.py # skellycam/core/camera/opencv/opencv_camera_loop.py # skellycam/core/camera/opencv/opencv_helpers/setup_opencv_camera_loop.py # skellycam/core/camera_group/camera_group.py # skellycam/core/camera_group/camera_group_manager.py # skellycam/core/camera_group/camera_orchestrator.py # skellycam/core/camera_group/camera_status.py # skellycam/core/ipc/shared_memory/camera_group_shared_memory.py # skellycam/core/types/frontend_payload_bytearray.py
Merging new hot nonsense from jon/development to /development. Will try to add framerate next, merging working commit before futzing with the guts --------- Co-authored-by: philipqueen <queen.philip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.