Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two new index-based lookup functions (At and AtKV) to the seq library, following the established dual API pattern. These functions allow retrieving values by their 0-based position in a sequence, complementing the existing Find family of functions that search by value or predicate.
Changes:
- Added
AtandAtKVfunctions for index-based lookup in sequences with proper error handling for negative and out-of-range indices - Added comprehensive example tests covering success, out-of-range, empty, and negative index cases
- Updated README documentation to list the new functions under the "Finding" section
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| seq.go | Implements At and AtKV functions with proper handling of edge cases (negative indices, out of range) |
| seq_test.go | Adds example tests for both functions covering various scenarios |
| README.md | Documents the new functions in the Search/Finding section |
| CLAUDE.md | Adds documentation note about Go version changes requiring #minor tag (minor documentation improvement) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.