Port to latest chisel-3.5 and add CI testing#20
Port to latest chisel-3.5 and add CI testing#20schoeberl merged 2 commits intofreechipsproject:masterfrom
Conversation
|
This subsumes #15 |
|
Tests on this PR currently fail due to: chipsalliance/chisel#2080 |
|
With the latest @schoeberl This PR is ready for review now. |
schoeberl
left a comment
There was a problem hiding this comment.
I assume the dependency on snapshot versions is just temporarily until Chisel 3.5 is out.
They way this is normally handled by other libraries in the chisel ecosystem is that all development happens against the latest snapshot versions and then releases to maven happen from a stable branch that tracks a release version of chisel. So in this case you could make a If you only want to depend on stable versions, we could delay merging this PR until the |
|
I am fine with this approach. We (me, you?) should just be aware of to publish a new version of this library (and others) when Chisel 3.5 is out. Looks like Chisel/Scala/Java library version handling is not that trivial. Maybe it cannot be ;-) |
No description provided.