Skip to content

Port to latest chisel-3.5 and add CI testing#20

Merged
schoeberl merged 2 commits intofreechipsproject:masterfrom
ekiwi:chisel-3.5
Aug 18, 2021
Merged

Port to latest chisel-3.5 and add CI testing#20
schoeberl merged 2 commits intofreechipsproject:masterfrom
ekiwi:chisel-3.5

Conversation

@ekiwi
Copy link
Collaborator

@ekiwi ekiwi commented Aug 18, 2021

No description provided.

@ekiwi
Copy link
Collaborator Author

ekiwi commented Aug 18, 2021

This subsumes #15

@ekiwi ekiwi marked this pull request as ready for review August 18, 2021 00:52
@ekiwi
Copy link
Collaborator Author

ekiwi commented Aug 18, 2021

Tests on this PR currently fail due to: chipsalliance/chisel#2080

@ekiwi
Copy link
Collaborator Author

ekiwi commented Aug 18, 2021

With the latest chisel3 snapshot, all tests pass.

@schoeberl This PR is ready for review now.

Copy link
Collaborator

@schoeberl schoeberl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the dependency on snapshot versions is just temporarily until Chisel 3.5 is out.

@ekiwi
Copy link
Collaborator Author

ekiwi commented Aug 18, 2021

I assume the dependency on snapshot versions is just temporarily until Chisel 3.5 is out.

They way this is normally handled by other libraries in the chisel ecosystem is that all development happens against the latest snapshot versions and then releases to maven happen from a stable branch that tracks a release version of chisel.

So in this case you could make a v0.4 branch that will always target the X.4 release and then we can merge this PR and the main branch will be the development against the latest Chisel.

If you only want to depend on stable versions, we could delay merging this PR until the X.5 release.

@schoeberl
Copy link
Collaborator

I am fine with this approach. We (me, you?) should just be aware of to publish a new version of this library (and others) when Chisel 3.5 is out. Looks like Chisel/Scala/Java library version handling is not that trivial. Maybe it cannot be ;-)

@schoeberl schoeberl merged commit aa85736 into freechipsproject:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants