Making NfInstanceId configurable #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niahh
force-pushed
the
nf-instance-id-configurable
branch
2 times, most recently
from
4239241 to
15dc233
Compare
Member
|
Hi @Niahh, Thanks again for your contribution. |
Initially the NF created at each boot a new uuid. This makes it difficult to retrieve the information afterwards. This commit propose is to add the nfInstanceId in the configuration as optional so that if needed, it can be tracked more easily. If no nfInstanceId specified in config file or env var, it will still be generated at each boot and give more control to users that might need it (for kube deployment, other checks, better identification) Also using the uuidv4 validator to match spec 3GPP TS 29.510 version 17.6.0 Release 17 5.2.2.2.2 mentioning that UUID should be in the version 4 format
Niahh
force-pushed
the
nf-instance-id-configurable
branch
from
15dc233 to
da9b098
Compare
Contributor
Author
Hi @Alonza0314, You are absolutely right, I forgot to update my branch, my bad 😅. It should be good now 😁 Cheers ! |
Alonza0314
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
This PR follows the one for the free5gc/amf#186 and adds the support for env var as well.
-> Upgrading google library from 1.3.0 to .1.6.0
Backward Compatibility
100% backward compatible
Cheers,
This work is sponsored by Free Mobile!