feat(PCF): Integrate BSF client for binding management #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Add BSF service client for PCF binding lifecycle: - Create bsf_service.go with CreatePCFBinding, DeletePCFBinding functions - Integrate BSF client into consumer.go for binding operations - Add BSF service configuration and discovery support • Enhance UE context management: - Update ue.go with BSF binding ID tracking - Integrate binding creation/deletion in SM policy lifecycle - Add proper cleanup of BSF bindings on session termination • Update SM policy processor: - Modify smpolicy.go to use BSF for binding management - Add BSF binding creation during policy establishment - Ensure proper binding cleanup on policy deletion This integration enables PCF to properly manage bindings with BSF according to 3GPP TS 29.521 specifications for enhanced policy control.
Resolved conflicts in smpolicy.go by preserving BSF integration functionality: - Maintained RegisterPCFBinding call during SM policy creation - Kept DeletePCFBinding call during policy deletion - Preserved UpdatePCFBinding call during policy updates - Combined both approaches to ensure full BSF lifecycle management All BSF binding operations are maintained while incorporating latest changes from the main branch.
- Add context import and convert http.NewRequest to http.NewRequestWithContext - Fix errcheck issues by adding proper resp.Body.Close() error handling - Fix lll (line length) issue by formatting long function call - Ensure all HTTP operations use proper context and error checking Functions updated: - RegisterPCFBinding: POST with context and error handling - UpdatePCFBinding: PATCH with context and error handling - DeletePCFBinding: DELETE with context and error handling - BSFSelection: Fixed long line formatting Fixes: errcheck, noctx, lll linting violations Tested: golangci-lint returns 0 issues
ianchen0119
reviewed
Sep 23, 2025
Contributor
|
The others look good to me. |
ianchen0119
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Add BSF service client for PCF binding lifecycle:
• Enhance UE context management:
• Update SM policy processor:
This integration enables PCF to properly manage bindings with BSF according to 3GPP TS 29.521 specifications for enhanced policy control.