-
Notifications
You must be signed in to change notification settings - Fork 129
Feature: Add IPv6 support #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
linouxis9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton :-) I've added a small comment!
|
@adjivas Hi, it seems like the commit message check got failed. Can you help to solve this error? |
|
@Alonza0314 Hello, sure it's did! I renamed fix into fixe, so now it's will pass |
I think it should be "fix" instead of "fixe".😆 |
|
I simply squash this commits into one :) |
|
Thanks, it looks great now. |
|
Hi @Alonza0314, Initial focus was on AMF as its the entrypoint of the 5GC, and it made sense to begin with it. AUSF/UDM followed as they are ones of the first NFs the AMF interacts with in the Registration call flow. Thanks and cheers, |
|
Hello @Alonza0314, everything is fine with this PRs (AMF, AUSF, UDM) ? Best see, |
|
Sorry for the late reply. These three PRs look good to me. After discussing with the team, we have decided to merge them once all NFs support IPv6 and pass the full tests. Really appreciate you proposing this feature—it’s a great step forward! Thanks again, |
|
Hi @adjivas I noticed that the PR has been closed for no reason. Thank you! |
|
Hello @ianchen0119 , yes, that was a mistake. I closed because it was superseded by PR#9. Today I haven't the lead on this task. But, here is all my IPv6 branches:
I tested it with an custom PacketRusher, I locally adapted it with a naive IPv6 support |
|
@adjivas |
|
Hi, thank you for pinging, I started this PR while I was working for a company and now that I left it, I am interested in seeing it through but only if the task is not up for grabs. Also, I don't have much time to dedicate to it so I will try my best to open all this PR soon as possible. |
|
Thanks for your reply. @linouxis9 Thanks! |
|
Hi, @adjivas It's open-source, you are of course free to continue working on these PRs! Thanks! |
Hello,
This PR adds the RegisterIP/BindingIP fields, we can set them with IPv4 or IPv6 values
For not introduce any breaking changes, the RegisterIPv4/BindingIPv4 are the fall back of the RegisterIP/BindingIP fields.
A lookup resolution is added to both RegisterIP/BindingIP
Additionally, I tested this PR with AUSF/UDM IPv6 (See free5gc/ausf#34 and free5gc/udm#48)
I checked it with my adaptation of the free5gc's tests: adjivas/free5gc#4