Feat: Improve file upload progress feedback#135
Merged
skyl merged 7 commits intofree2z:mainfrom Mar 17, 2025
Merged
Conversation
…r certain domains
skyl
approved these changes
Mar 17, 2025
Contributor
skyl
left a comment
There was a problem hiding this comment.
I like it. Sometimes for small files it's so fast that maybe it's a little jolting but I think for large files it will be very helpful.
Contributor
Author
|
Think I can manage to make it smoother for small files, would make another pr. @skyl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the user experience during file uploads by providing clearer visual feedback about the upload and server processing stages.
Problem
Currently, when a user uploads files, the progress bar often stops at around 98% while the server processes the files (moving them to cloud storage, etc.). This can make users think the upload is stuck or has failed, potentially leading them to cancel the operation prematurely.
Solution
Implemented a two-stage progress indicator:
Changes
processingit shows theLoadingAnimationcomponent inside a MUI Box component with some text.LinearProgressBackdropis usedExplanation
It seems that the
progressEvent.totalvalue changes at some point during the process. This might indicate that Axios somehow detects two separate operations taking place on the server. Taking advantage of this, you can identify the moment when the file has been successfully uploaded. At this point, you can stop displaying the progress bar and instead switch to showing theLoadingAnimationcomponent.Testing
Related Issues
Fixes #125