Feature/auv2 musiceffect support #415
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to create an AUv2 plugin of type "aumf" (music effect) when the MACOSX_EMBEDDED_CLAP_LOCATION is set.
In the first commit I made INSTRUMENT_TYPE take precedence over setting the plugin type based on the present CLAP features. This way you could also create all the other possible AUv2 plugin types.
In the second commit I changed the automatic AUv2 plugin type assignment a bit. When the CLAP plugin has both the AudioEffect and the Instrument feature the "aumf" plugin type is assigned. Also, this checks the whole set of features, instead of only the first.
I wouldn't be surprised if this not mergeable yet. Maybe I'm missing some caveats. But I'd be happy to contribute. I could also turn this into an issue if this is way off.