Add webview GUI #10
Open
Add webview GUI #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a webview GUI using the
clap.webview/2draft extension. Since this is not included inclap-helpersyet, we have to do a bit more manual checking for it.The page is a
data:URI, which just appends all log messages to the page. Here's an example of what it looks like.It currently uses CLAP's
next, since the webview extension hasn't yet made it tomain. It probably makes sense to wait for that (so we can continue usingmain), but this is here for review in the meantime.Similarly, webview draft-extension support could be added to
clap-helpers, but I'm less sure whether that's a blocking issue or not.