Skip to content

Conversation

@tarnith
Copy link

@tarnith tarnith commented May 4, 2023

Moved the hardcoded directory to at least C;\temp so the chance of overwriting existing files is reduced. Perhaps a check for existing directores before wiping data would be advised.

Moved the hardcoded directory to at least C;\temp so the chance of overwriting existing files is reduced. 
Perhaps a check for existing directores before wiping data would be advised.
@CLAassistant
Copy link

CLAassistant commented May 4, 2023

CLA assistant check
All committers have signed the CLA.

@abique
Copy link
Contributor

abique commented May 5, 2023

Did you confirm that the path was short enough to build qt using vcpkg?

@tarnith
Copy link
Author

tarnith commented May 5, 2023

Can't confirm as can't complete build due to other build errors.

Perhaps a better PR would be a simple
if [ -d "/path/to/directory" ]; then echo "Directory exists. Delete or choose another buildtree" break

I notice some other build scripts also hard code C:\B which is unfortunately a preexisting folder on my system for other things requiring a short path.
vcpkgerror.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants