Prevent window to be called #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lojjic
reviewed
Feb 22, 2024
| return s; | ||
| }, | ||
| _tdec : typeof window !== 'undefined' && window["TextDecoder"] ? new window["TextDecoder"]() : null, | ||
| _tdec : function() { |
There was a problem hiding this comment.
You've changed the type of _tdec from TextDecoder | null to a function, so this would certainly break...?
I think maybe a better approach would be to check for TextDecoder global directly?
_tdec : typeof TextDecoder !== 'undefined' ? new TextDecoder() : null
There's probably also some adjustment to be made in troika-three-text where it tries to hack in worker support.
Author
There was a problem hiding this comment.
Thank you for your reply.
I'm gonna open an issue in the Drei repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When using the Text component of React Drei in a Next.js project, I get this error :
I invested the problem, and the Text component uses Troika Text, which uses Typr.
To be honest, I don't know really why there is this error, but by encapsulating the
_tdecresult in a function, the error is gone.Can this change could create some side effect?
Dependency order :
https://github.com/pmndrs/drei
https://github.com/protectwise/troika
https://github.com/protectwise/troika/tree/main/packages/troika-three-text
https://github.com/fredli74/Typr.ts