Skip to content

Conversation

@chris-martin
Copy link
Contributor

@chris-martin chris-martin commented Apr 24, 2025

@chris-martin chris-martin requested a review from pbrisbin April 24, 2025 07:45
pbrisbin
pbrisbin previously approved these changes Apr 24, 2025
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used the template property in GHVM, but couldn't a lot of this have come from our haskell-library-template?

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chris-martin
Copy link
Contributor Author

couldn't a lot of this have come from our haskell-library-template?

I did copy most of it from there

@chris-martin
Copy link
Contributor Author

Older Stack resolver support blocked by freckle/debug-print#8

chris-martin and others added 3 commits April 24, 2025 13:13
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chris-martin
Copy link
Contributor Author

Stackage nightly is blocked by biocad/openapi3#109

@chris-martin chris-martin marked this pull request as ready for review April 24, 2025 22:05
@chris-martin chris-martin requested a review from pbrisbin April 24, 2025 22:06
@chris-martin
Copy link
Contributor Author

Alright, done fiddling with the build, ready to go. I still like the module organization but lmk if you want me to change it.

pbrisbin
pbrisbin previously approved these changes Apr 25, 2025
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change module organization. I see no upside to it, but no downside either.

@chris-martin
Copy link
Contributor Author

Dug a little deeper to figure out how to generate a wider character set.

Also expanded the Host generator to also be able to generate IpV4 hosts. Discovered that IPv6 doesn't work - nikita-volkov/iri#2

@chris-martin chris-martin merged commit b83f84b into main Apr 28, 2025
6 of 7 checks passed
@chris-martin chris-martin deleted the chris/init branch April 28, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants