Move markdown-unlit to build-tools #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids unused-package warnings and removes the need for empty imports. 🤖 Generated with Claude Code
derelbenkoenig
requested review from
chris-martin
and removed request for
a team
Contributor
Author
|
fun, a new deprecation warning |
Change from nightly-2023-07-25 to nightly to use the current nightly snapshot. Co-Authored-By: robert.benson@renaissance.com <derelbenkoenig@gmail.com>
Replace deprecated 'split' function with 'splitGen' for compatibility with newer random library versions in nightly snapshots Co-Authored-By: robert.benson@renaissance.com <derelbenkoenig@gmail.com>
The split function is deprecated but will remain available for backward compatibility. Using splitGen breaks older Stack resolvers that don't have the SplitGen type class. Added pragma to suppress deprecation warning. Co-Authored-By: robert.benson@renaissance.com <derelbenkoenig@gmail.com>
Specify nightly-2025-09-23 instead of just 'nightly' for reproducible builds. Co-Authored-By: robert.benson@renaissance.com <derelbenkoenig@gmail.com>
chris-martin
approved these changes
Sep 24, 2025
derelbenkoenig
deleted the
markdown-unlit-build-tools-20250923-164527
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves
markdown-unlitfromdependenciestobuild-toolsin the package.yaml test configuration and removes the corresponding empty import from README.lhs.Why this change?
When
markdown-unlitis listed independencies, we need to import it in the Haskell code to avoid unused-package warnings from GHC. However, sincemarkdown-unlitis only used as a preprocessor (via-pgmL markdown-unlit), we don't actually need to import anything from it in our code.By moving it to
build-toolsinstead, we:Changes
markdown-unlitfromdependenciestobuild-toolsin package.yamlimport Text.Markdown.Unlit ()from README.lhsstack build --fast --test --no-run-tests🤖 Generated with Claude Code