Use prettyprinter for annotateFailureReason #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I attempted do this is the least disruptive way. At this point, there's almost no value in prettyprinter being used. What I've done amounts to switching `T.pack` for `pretty` and `T.intercate "\n"` for `vsep`, and adding a pretty pointless layout and render step. However, I plan to take more advantage in future commits.
And don't use tabs.
Member
Author
|
This is part of #203, I decided to work on it in place because that's more fun than moving it. |
pbrisbin
commented
Jan 13, 2026
Comment on lines
+185
to
+188
| , " * Annotation @Text \"Visibility is poor. Visability is poor. Visability is" | ||
| , " poor. Visability is poor. Visability is poor. Visability is poor. Visability" | ||
| , " is poor. Visability is poor. Visability is poor. Visability is poor." | ||
| , " Visability is poor\"" |
Member
Author
There was a problem hiding this comment.
As mentioned in the commit, using a prettyprinter for this case isn't really doing a whole lot. If it weren't already a transitive dependency, I'd be hesitant to pull it in just for this. This smart reflow is really the only thing we're getting from it, so at least there's something.
pbrisbin
commented
Jan 13, 2026
| let-style: mixed | ||
| in-style: left-align | ||
| single-constraint-parens: never # ignored until v12 / ghc-9.6 | ||
| trailing-section-operators: false # needs fourmolu >= v0.17 |
Member
Author
There was a problem hiding this comment.
This made the diff a little noisier; sorry I didn't do a better job isolating it.
chris-martin
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak fourmolu
1cb7a3c
Use prettyprinter for annotateFailureReason
c71984f
I attempted do this is the least disruptive way. At this point, there's
almost no value in prettyprinter being used. What I've done amounts to
switching
T.packforprettyandT.intercate "\n"forvsep, andadding a pretty pointless layout and render step.
However, I plan to take more advantage in future commits.
Neatly align listed annotations
c336c14
And don't use tabs.
Use hardline, not literal
7ecb236