Fix issue regarding compatibility in updated R version#74
Open
lucillelu530 wants to merge 2 commits intofrbl:masterfrom
Open
Fix issue regarding compatibility in updated R version#74lucillelu530 wants to merge 2 commits intofrbl:masterfrom
lucillelu530 wants to merge 2 commits intofrbl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change in R/OnlineSuperLearner.R, where a function named
get_validty()in the R6 class. The update fixes the logic used to validate summary_measure_generator so that the validity check only throws an error when the generator is missing or not of class SummaryMeasureGenerator, instead of incorrectly failing in valid cases; it also avoids errors caused by class() returning multiple values by ensuring the condition evaluates to a single TRUE/FALSE.