feat(challenges): display up to 10 nendys in help text#422
Open
johnsyweb wants to merge 2 commits intofraz3alpha:masterfrom
Open
feat(challenges): display up to 10 nendys in help text#422johnsyweb wants to merge 2 commits intofraz3alpha:masterfrom
johnsyweb wants to merge 2 commits intofraz3alpha:masterfrom
Conversation
Add comprehensive tests for the functionality added in commit f938ea9: - Tests for new formatEventWithDistance helper function - Updated tests for enhanced generate_stat_nearest_event_not_done_yet - Tests for displaying up to 10 nearest events in help text - Edge case tests for events without coordinates - All tests pass with proper formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
My parkrun buddy is overseas. I would like to do an event I've not done yet but am saving the ones my buddy hasn't done until their return, so I'd like to be able to easily view the ten nearest events I've not done yet.
Change
Display up to ten nearest events in the help text. Pleasingly, this is exactly the same number of lines of code, thanks to some minor optimisations.
Confirmation
Added tests, too.