Skip to content

Alternative origins for Record Breaker#413

Open
johnsyweb wants to merge 6 commits intofraz3alpha:masterfrom
johnsyweb:paj/record-fixer
Open

Alternative origins for Record Breaker#413
johnsyweb wants to merge 6 commits intofraz3alpha:masterfrom
johnsyweb:paj/record-fixer

Conversation

@johnsyweb
Copy link
Contributor

Context

My first overseas parkrun skewed this challenge so much it's entirely unattainable unless I move state. This is likely true for many other parkrunners.

#398 shows that the challenge is broken for those who've yet to complete a 5k.

Change

  • If we're on our own page, and we've set a home parkrun, use this as the centre for the Record Breaker challenge.
  • If we're not on our own page, or we've not set a home parkrun, use the "average parkrun" as the origin for the Record Breaker challenge. For many, this will be their home run.
  • If there's no calculable Record Breaker challenge, use the original origin: Bushy Park!

Confirmation

Incoming!

Considerations

I'm not strongly tied to this implementation and won't be offended if it's rejected.

@johnsyweb johnsyweb marked this pull request as draft October 26, 2024 05:24
@johnsyweb johnsyweb marked this pull request as ready for review October 26, 2024 06:36
var reference_parkrun_name = calculate_average_parkrun_event_name(parkrunResults, geoData)
const reference_parkrun_name = user_data?.home_parkrun_info?.name ??
calculate_average_parkrun_event_name(parkrunResults, geoData) ??
'Bushy Park';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant