Skip to content

Reports the start and finish events (and dates) for a tourism streak#387

Open
johnsyweb wants to merge 8 commits intofraz3alpha:masterfrom
johnsyweb:paj/test-tourism-streak
Open

Reports the start and finish events (and dates) for a tourism streak#387
johnsyweb wants to merge 8 commits intofraz3alpha:masterfrom
johnsyweb:paj/test-tourism-streak

Conversation

@johnsyweb
Copy link
Contributor

@johnsyweb johnsyweb commented May 14, 2023

Context

I was (temporarily) confused yesterday by my longest tourism streak being bookended by two different events. So I thought I'd write some tests to prove that the current implementation was correct. As I did this, I also thought that it would be nice to display the start and finish of a streak so that folks with very long streaks can see this at a glance without having to count.

Change

  • Ensures web-ext is installed (I forget this every time I work on this extension)
  • Documents running local unit tests (and also updated the Selenium docs)
  • Adds first test
  • Allows tests to set any field
  • Tests existing behaviour
  • Reports the start and finish events (and dates) for a tourism streak

Confirmation

Before

Screenshot 2023-05-14 at 13-43-06 results parkrun Australia

After

Screenshot 2023-05-14 at 13-24-57 results parkrun Australia

Cheers! 🍻

Thanks again for this plugin, it brings many people a lot of joy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant