Reports the start and finish events (and dates) for a tourism streak#387
Open
johnsyweb wants to merge 8 commits intofraz3alpha:masterfrom
Open
Reports the start and finish events (and dates) for a tourism streak#387johnsyweb wants to merge 8 commits intofraz3alpha:masterfrom
johnsyweb wants to merge 8 commits intofraz3alpha:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I was (temporarily) confused yesterday by my longest tourism streak being bookended by two different events. So I thought I'd write some tests to prove that the current implementation was correct. As I did this, I also thought that it would be nice to display the start and finish of a streak so that folks with very long streaks can see this at a glance without having to count.
Change
web-extis installed (I forget this every time I work on this extension)Confirmation
Before
After
Cheers! 🍻
Thanks again for this plugin, it brings many people a lot of joy!