Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 20, 2025

Summary

Removes the maven.yml workflow that uses JDK 21, as it's no longer needed after the introduction of the Loom Build Tests workflow in #27.

Background

The project requires Java 26 features and uses Project Loom's virtual threads. After #27 added the loom-tests.yml workflow that uses the latest Loom JDK from shipilev.net, maintaining a separate JDK 21 workflow became redundant.

Changes

  • Removed .github/workflows/maven.yml (Java CI with Maven / build workflow using JDK 21)
  • Kept .github/workflows/loom-tests.yml (Loom Build Tests / test-with-loom workflow)

Rationale

  • The Loom Build Tests workflow provides more recent JDK features required by this project (Java 26)
  • Single workflow reduces maintenance overhead and CI runtime
  • The Loom build from shipilev.net includes all necessary features for building and testing this project

Closes #28

Original prompt

This section details on the original issue you should resolve

<issue_title>Don't run Java CI with Maven / build (push) with JDK 21 anymore</issue_title>
<issue_description>After #27 there is no need for running the JDK 21 workflow on master, but just Loom Build Tests / test-with-loom (push) .
Remove the JDK 21 related workflows.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #29


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: franz1981 <13125299+franz1981@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove JDK 21 related workflows from master Remove JDK 21 workflow after Loom Build Tests implementation Oct 20, 2025
Copilot AI requested a review from franz1981 October 20, 2025 02:56
@franz1981 franz1981 marked this pull request as ready for review October 20, 2025 02:57
@franz1981 franz1981 merged commit b45d53d into master Oct 20, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't run Java CI with Maven / build (push) with JDK 21 anymore

2 participants