Skip to content

Conversation

@russellbanks
Copy link

This pull request updates bitflags to major version 2. The major difference that affects this library is that fewer traits are derived so we have to derive them ourselves.

The minimum this library actually needs is #[derive(Copy, Clone, Debug, Eq, PartialEq)] but this could be a breaking change if we derive less than there were previously, so this pull request derives all traits that existed in bitflags 1, as suggested in the release notes:

Generated flags types now derive fewer traits. If you need to maintain backwards compatibility, you can derive the following yourself:

#[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Debug, Clone, Copy)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant