Update bitflags to 2 #13
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates bitflags to major version 2. The major difference that affects this library is that fewer traits are derived so we have to derive them ourselves.
The minimum this library actually needs is
#[derive(Copy, Clone, Debug, Eq, PartialEq)]but this could be a breaking change if we derive less than there were previously, so this pull request derives all traits that existed in bitflags 1, as suggested in the release notes: