new use case and enforcing odd parity of PSFs#5
Open
rchwn wants to merge 4 commits intofrancbelf:masterfrom
Open
new use case and enforcing odd parity of PSFs#5rchwn wants to merge 4 commits intofrancbelf:masterfrom
rchwn wants to merge 4 commits intofrancbelf:masterfrom
Conversation
…ding - kernel_core: force odd dimensions when skipping resample (match resample behavior) - kernel_core: add filename_suffix parameter to save_processed_psf() - make_psf: fix detector_oversample parameter extraction (was popping oversample_factor twice) - make_psf: add warnings when detector_oversample is even - make_psf: forward kwargs in read_PSF() for auto-generation support Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Issue #4
I made a minor change to
make_psf.py, where the resample factor is now set to 5 (from 4) and parity is forced to be odd. This ensures the PSF generated bystpsfhas the peak centered on a single pixel.The other change is the addition of a new function
process_source_psf()inkernel_core.pyso that one can instantiate the parent class without needing to refer to a target PSF, and save the processed source PSF (same Aniano processing from the original version ofkernel_core.py). Just copied it to a new function. The other tweaks are to make the init logic work as planned.I put some test scripts along with the version of
kernel_core.pyin thenotebooks/folder.@francbelf @akleroy @thomaswilliamsastro