[SELS-TASK-25] [BE]- Enable Authguards for the Lesson Quiz endpoint #26
+329
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fontilllas
force-pushed
the
SPH-ELS-MARK-25
branch
2 times, most recently
from
5ace4dd to
72ab404
Compare
Collaborator
|
I encountered some errors after running docker compose up on my end. Please fix.
|
Fontilllas
force-pushed
the
SPH-ELS-MARK-25
branch
2 times, most recently
from
a002c38 to
6b7c269
Compare
escbooster12-dev
requested changes
Jan 17, 2024
| private choicesService: ChoicesService, | ||
| private jwtService: JwtService, | ||
| private userService: UserService | ||
| private readonly userService: UserService, |
Collaborator
There was a problem hiding this comment.
why is this set to readonly?
| async getChoices(@Param('wordId') wordId: number, @Req() request: Request) { | ||
| const cookie = request.cookies['jwt']; | ||
| const { id: user_id } = await this.jwtService.verifyAsync(cookie); | ||
| const user = await this.userService.findOne({ where: { user_id } }); |
Collaborator
There was a problem hiding this comment.
this will be catered in auth.middleware.
no need for this so pls remove.
Comment on lines
100
to
104
| if (user) { | ||
| return formattedData; | ||
| } else { | ||
| throw new NotFoundException('Forbidden Resources'); | ||
| } |
Collaborator
There was a problem hiding this comment.
also remove this condition
| signOptions: { expiresIn: '1d' }, | ||
| }), | ||
| TypeOrmModule.forFeature([Category, Words, Choices, User]), | ||
| TypeOrmModule.forFeature([Category, Words, Choices,User]), |
Collaborator
There was a problem hiding this comment.
change is not necessary. pls rever it back to original
| }), | ||
| TypeOrmModule.forFeature([Category, Words, Choices, User]), | ||
| TypeOrmModule.forFeature([Category, Words, Choices,User]), | ||
| ], |
Collaborator
There was a problem hiding this comment.
i think code still formatted. can you setup prettier.
Mjdelima20
reviewed
Jan 17, 2024
| import { In } from 'typeorm'; | ||
| import { AuthGuard } from 'src/auth/auth.guard'; | ||
| import { Request } from 'express'; | ||
| import { request } from 'http'; |
Collaborator
There was a problem hiding this comment.
pls remove this , since request is not being use.
Mjdelima20
reviewed
Jan 17, 2024
| private choicesService: ChoicesService, | ||
| private jwtService: JwtService, | ||
| private userService: UserService | ||
| private readonly userService: UserService |
Fontilllas
force-pushed
the
SPH-ELS-MARK-25
branch
from
ddd190a to
ef98c2e
Compare
Fontilllas
changed the title
Fontilllas
force-pushed
the
SPH-ELS-MARK-25
branch
from
ef98c2e to
3744cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana
[Commands]
docker compose up[Pre-conditions]
[Expected Output]
[Screenshots]
Details