[SELS-TASK]-[FE]-Mockup Results Page #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import Done from "../components/common/Done"; | ||
| import Navbar from "../components/common/Navbar"; | ||
| import QuizHeader from "../components/common/QuizHeader"; | ||
| import DummyTest from "../dummytest"; |
Collaborator
There was a problem hiding this comment.
For dummy data, please store it in the exact location where it is being used since this is temporary and removable in the future
apply to all related
| @@ -0,0 +1,67 @@ | |||
| import ChoicesButton from "../components/common/ChoicesButton"; | |||
| import Done from "../components/common/Done"; | |||
| import Navbar from "../components/common/Navbar"; | |||
Collaborator
There was a problem hiding this comment.
can you setup module path alias.
|
|
||
| const LessonAnswerPage = () => { | ||
| const Items = DummyTest.length; | ||
| const [question, setQuestion] = useState(0); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const [question, setQuestion] = useState(0); | |
| const [questionIndex, setQuestionIndex] = useState(0); |
| import { useState } from "react"; | ||
|
|
||
| const LessonAnswerPage = () => { | ||
| const Items = DummyTest.length; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const Items = DummyTest.length; | |
| const totalQuestions = DummyTest.length; |
| import Done from "../components/common/Done"; | ||
| import Navbar from "../components/common/Navbar"; | ||
| import QuizHeader from "../components/common/QuizHeader"; | ||
| import DummyTest from "../dummytest"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| import DummyTest from "../dummytest"; | |
| import dummyQuestions from "../dummyQuestions"; |
Comment on lines
15
to
17
| if (isCorrect === true) { | ||
| setScore(score + 1); | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (isCorrect === true) { | |
| setScore(score + 1); | |
| } | |
| if (isCorrect) { | |
| setScore(score + 1); | |
| } |
escbooster12-dev
requested changes
Dec 7, 2023
Collaborator
There was a problem hiding this comment.
The PR requires refactoring and proper structuring. Let's begin by addressing the essential configurations for this PR.
I'd like you to set up:
- Eslint
- Prettier
- Typescript
- Husky
Please create a separate a task and a PR to implement the above setup alongside the module import changes you made in this PR. Do the setup for each frontend and backend
You may follow this as reference
3 tasks
Mjdelima20
force-pushed
the
SPH-ELS-MARK-15
branch
from
71a16f5 to
2d250e8
Compare
escbooster12-dev
requested changes
Jan 11, 2024
frontend/src/Routes/routes.tsx
Outdated
Comment on lines
2
to
8
| import HomePage from '../Pages/Homepage'; | ||
| import CategoryPage from '../Pages/Categorypage'; | ||
| import LoginPage from '../Pages/auth/LoginPage'; | ||
| import SignUp from '../Pages/auth/SignupPage'; | ||
| import AdminLogin from '../Pages/auth/AdminLogin'; | ||
| import AdminSignin from '../Pages/auth/AdminSignUp'; | ||
| import Dashboard from '../Pages/Dashboard'; |
| </p> | ||
|
|
||
| <Link to={'#resultspage'}> | ||
| <Link to={'/category/1/result'}> |
Collaborator
There was a problem hiding this comment.
why is this static to 1?
Comment on lines
10
to
21
| return ( | ||
| <> | ||
| <div | ||
| className={clsx('text-gray-700', { | ||
| 'mx-[6rem] w-[5rem] ': question === true, | ||
| 'mx-[11rem]': !question, | ||
| })} | ||
| > | ||
| {answer} | ||
| </div> | ||
| </> | ||
| ); |
Collaborator
There was a problem hiding this comment.
Suggested change
| return ( | |
| <> | |
| <div | |
| className={clsx('text-gray-700', { | |
| 'mx-[6rem] w-[5rem] ': question === true, | |
| 'mx-[11rem]': !question, | |
| })} | |
| > | |
| {answer} | |
| </div> | |
| </> | |
| ); | |
| return ( | |
| <div | |
| className={clsx('text-gray-700', { | |
| 'mx-[6rem] w-[5rem] ': question === true, | |
| 'mx-[11rem]': !question, | |
| })} | |
| > | |
| {answer} | |
| </div> | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana
[Commands]
npm start[Pre-conditions]
/resultin the URLnote: if you want to change the score, access frontend folder
- access src
- access dummyresult.tsx
- match the answer to correct_answer
[Expected Output]
[Screenshots]
Details
results.mp4