Fix/2 9 1 plus cert renewal panic fix cherry pick #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6761) * log: Only chmod if permission bits differ Follow-up to caddyserver#6314 and https://caddy.community/t/caddy-2-9-0-breaking-change/27576/11 * Fix test * Refactor FileWriter * Ooooh octal... right...
Fixes a panic where rr.stream is not true when it should be in the event of 1xx, because the buf is nil
Member
|
Using this branch as a temp "breadcrump" to have an overview of what Caddy the FramerDomainsServer is running Also cherry picked this commit from Caddy (upstream): caddyserver@1115158 (which will be go-getted in FramerDomainsServer) |
Collaborator
|
Closing: The branch is obsolete (we've added more on top of it), and the current deployed caddy is e37961a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest caddy version, with some fixes that Matt did to solve some issues (see https://framer-team.slack.com/archives/C06505JMQK0/p1737373399749029)