Major change for ssb-custom-uri compatibility.#1
Major change for ssb-custom-uri compatibility.#1soapdog wants to merge 1 commit intofraction:masterfrom
ssb-custom-uri compatibility.#1Conversation
This changes grammars and associated routines to make it compatible with `ssb-custom=uri`.
|
Nice! I'm concerned about breaking compatibility because this is used in a few apps, do you think we could make this a backward-compatible change instead? It also looks like your spec uses URL-unsafe characters, which we could support but I think it's important to me that we could support the URL-safe base64 alphabet as well. |
|
@christianbundy can you elaborate a bit more in what you mean about me using URL-unsafe characters? I'm url encoding them so I thought they are safe. The What do you think? |
|
Sorry, I mean "URI-safe" as in "you don't need to URI encode them for them to be a valid URL". I think I'd like to continue adding support for other URI formats but would prefer not to break backward-compatibility. I don't mind if we have a few different URI formats, e.g.
|
This changes grammars and associated routines to make it compatible with
ssb-custom=uri.