Make compatiable with cs on haxe 4.3.6#295
Open
sholom996 wants to merge 2 commits intofponticelli:masterfrom
Open
Make compatiable with cs on haxe 4.3.6#295sholom996 wants to merge 2 commits intofponticelli:masterfrom
sholom996 wants to merge 2 commits intofponticelli:masterfrom
Conversation
Object.removePath had been simply patched out String.toCharcodes had been adjusted so haxecs generates proper cast
Owner
|
I do not love that we remove functionality, could the CS implementation be fixed? |
Author
|
Hi
The problem is that I do not understand exactly the flow of that function,
Also maybe the function is in general too dynamic for CS to handle it.
בתאריך יום ג׳, 1 ביולי 2025 ב-13:31 מאת Franco Ponticelli <
***@***.***>:
… *fponticelli* left a comment (fponticelli/thx.core#295)
<#295 (comment)>
I do not love that we remove functionality, could the CS implementation be
fixed?
—
Reply to this email directly, view it on GitHub
<#295 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYEZ6QAEV3ZU3XGYXJ5CKA33GJPQ3AVCNFSM6AAAAACAQUZXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMRTGI3TSMJZG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thx.core had 2 type issues that prevented to use this library on cs projects.
I fixed 1 of them' the other I just commented out the function body for cs' this means that the function and its deriavitives cannot be used in hxcs I added a trace to avoid confusion.