Open
Conversation
mkniewallner
force-pushed
the
feat/non-dev-dependency-groups
branch
from
d39baf9 to
bd6123b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
=====================================
Coverage 93.4% 93.4%
=====================================
Files 38 38
Lines 1036 1046 +10
Branches 103 105 +2
=====================================
+ Hits 968 978 +10
Misses 54 54
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkniewallner
force-pushed
the
feat/non-dev-dependency-groups
branch
from
bd6123b to
70b0ae7
Compare
mkniewallner
force-pushed
the
feat/non-dev-dependency-groups
branch
from
70b0ae7 to
1f654e6
Compare
fpgmaas
reviewed
Feb 9, 2026
Owner
There was a problem hiding this comment.
Shouldn't we pass the argument to the other DependencyGetter's as well? Now we only seem to pass it to PoetryDependencyGetter.
fpgmaas
reviewed
Feb 9, 2026
| with Path("pyproject.toml").open("w") as f: | ||
| f.write(fake_pyproject_toml) | ||
|
|
||
| getter = PEP621DependencyGetter(config=Path("pyproject.toml"), non_dev_dependency_groups=("group2",)) |
Owner
There was a problem hiding this comment.
See comment above; now we don't seem to test if the field introduced by the PR works as expected in the DependencyGetterBuilder. Should we add/modify an existing functional test too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1376.
PR Checklist
docsis updatedDescription of changes
Add a new
--non-dev-dependency-groupsargument (andnon_dev_dependency_groupsconfiguration equivalent) to be able to specify groups from[dependency-groups]section that should be treated as containing regular dependencies instead of development ones.