pre-commit: move target directory from entry to args#1392
Open
GideonBear wants to merge 2 commits intofpgmaas:mainfrom
Open
pre-commit: move target directory from entry to args#1392GideonBear wants to merge 2 commits intofpgmaas:mainfrom
entry to args#1392GideonBear wants to merge 2 commits intofpgmaas:mainfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Ref #840
Previously, running deptry in pre-commit when using a
srcdirectory:DEP003 'mypackage' imported but it is a transitive dependencyargs: [ src ], results in double reportsentry: deptry src, provides the correct behaviorHowever,
entryis supposed to be an internal implementation detail, whileargsis meant for users to override. In this PR I've moved the directory toargsso it can be overridden byargs: [ "src" ]instead.This is a breaking change, since anyone using
args: [ "--something" ]will now be runningdeptry --somethinginstead ofdeptry . --something, and need to edit their config toargs: [ ".", "--something" ]. So feel free to deny if this isn't important enough to warrant that.