eslint rules

.eslintrc.json

@@ -8,81 +8,90 @@
       "files": [
         "*.ts"
       ],
+      "plugins": [
+        "jasmine"
+      ],
       "extends": [
 //        "eslint:recommended",
 //        "plugin:@typescript-eslint/recommended",
         "plugin:@angular-eslint/recommended",
-        "plugin:@angular-eslint/template/process-inline-templates"
+        "plugin:@angular-eslint/template/process-inline-templates",
+        "plugin:jasmine/recommended"
       ],
+      "env": {
+        "jasmine": true
+      },
       "rules": {
         "array-bracket-spacing": ["error", "always", { "objectsInArrays": false, "arraysInArrays": false, "singleValue": false }],
         "array-callback-return": "error",
-        "@typescript-eslint/ban-types": ["error", { "types": { "fdescribe": "Don't focus tests", "fit": "Don't focus tests" }}],
+        "@typescript-eslint/ban-types": "error",
         "camelcase": "error",
-        "comma-dangle": ["error", "always-multiline"]
-//        "@angular-eslint/component-class-suffix": ["error"],
-//        "@angular-eslint/component-selector": ["error", { "prefix": "exo", "style": "kebab-case", "type": "element" }],
-//        "curly": "error",
-//        "default-case": "error",
-//        "default-case-last": "error",
-//        "@angular-eslint/directive-class-suffix": ["error"],
-//        "@angular-eslint/directive-selector": ["error", { "prefix": "exo", "style": "camelCase", "type": "attribute" }],
-//        "dot-notation": "error",
-//        "eqeqeq": ["error"],
-//        "@typescript-eslint/explicit-function-return-type": "error",
-//        "getter-return": "error",
-//        "indent": ["error", 2, { "SwitchCase": 1 }],
-//        "max-len": ["error", 140],
-//        "max-lines": ["warn", { "max": 10000, "skipBlankLines": true, "skipComments": true }],
-//        "max-lines-per-function": ["warn", { "max": 1500, "skipBlankLines": true, "skipComments": true }],
-//        "max-statements": ["warn", 300],
-//        "no-alert": "error",
-//        "no-bitwise": "warn",
-//        "no-compare-neg-zero": "warn",
-//        "@angular-eslint/no-conflicting-lifecycle": "error",
-//        "no-console": ["error"],
-//        "no-const-assign": "error",
-//        "no-debugger": "error",
-//        "no-dupe-args": "error",
-//        "no-dupe-class-members": "error",
-//        "no-dupe-else-if": "error",
-//        "no-dupe-keys": "error",
-//        "no-duplicate-case": "error",
-//        "no-duplicate-imports": "error",
-//        "no-empty": ["error", { "allowEmptyCatch": true }],
-//        "no-empty-function": "error",
-//        "@angular-eslint/no-empty-lifecycle-method": "error",
-//        "no-eval": "warn",
-//        "no-extra-semi": "error",
-//        "no-irregular-whitespace": "error",
-//        "no-lonely-if": "error",
-//        "no-multi-spaces": ["error", { "ignoreEOLComments": false }],
-//        "no-multiple-empty-lines": ["error", { "max": 1 }],
-//        "no-restricted-imports": ["error", "rxjs/Rx", "fs"],
-//        "no-self-assign": "error",
-//        "no-self-compare": "error",
-//        "no-setter-return": "error",
-//        "no-sparse-arrays": "error",
-//        "no-template-curly-in-string": "error",
-//        "no-throw-literal": "error",
-//        "no-trailing-spaces": "error",
-//        "no-unreachable": "error",
-//        "no-unreachable-loop": "error",
-//        "no-unsafe-optional-chaining": "error",
-//        "no-unused-expressions": "error",
-//        "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
-//        "no-use-before-define": ["error", { "functions": false, "classes": false, "variables": true, "allowNamedExports": false }],
-//        "no-whitespace-before-property": ["error"],
-//        "object-curly-spacing": ["error", "always"],
-//        "prefer-const": "error",
-//        "quotes": ["error", "single"],
-//        "radix": "off",
-//        "require-jsdoc": "error",
-//        "semi": ["error", "always"],
-//        "use-isnan": ["error", { "enforceForSwitchCase": true }],
-//        "@angular-eslint/use-lifecycle-interface": "error",
-//        "@angular-eslint/use-pipe-transform-interface": "error",
-//        "valid-typeof": "error"
+        "comma-dangle": ["error", "always-multiline"],
+        "@angular-eslint/component-class-suffix": ["error"],
+        "@angular-eslint/component-selector": ["error", { "prefix": "exo", "style": "kebab-case", "type": "element" }],
+        "curly": "error",
+        "default-case": "error",
+        "default-case-last": "error",
+        "@angular-eslint/directive-class-suffix": ["error"],
+        "@angular-eslint/directive-selector": ["error", { "prefix": "exo", "style": "camelCase", "type": "attribute" }],
+        "dot-notation": "error",
+        "eqeqeq": ["error"],
+        "@typescript-eslint/explicit-function-return-type": "error",
+        "getter-return": "error",
+        "indent": ["error", 2, { "SwitchCase": 1 }],
+        "max-len": ["error", 140],
+        "max-lines": ["warn", { "max": 1500, "skipBlankLines": true, "skipComments": true }],
+        "max-lines-per-function": ["warn", { "max": 10, "skipBlankLines": true, "skipComments": true }],
+        "max-statements": ["warn", 10],
+        "no-alert": "error",
+        "no-bitwise": "warn",
+        "no-compare-neg-zero": "error",
+        "@angular-eslint/no-conflicting-lifecycle": "error",
+        "no-console": ["error"],
+        "no-const-assign": "error",
+        "no-debugger": "error",
+        "no-dupe-args": "error",
+        "no-dupe-class-members": "error",
+        "no-dupe-else-if": "error",
+        "no-dupe-keys": "error",
+        "no-duplicate-case": "error",
+        "no-duplicate-imports": "error",
+        "no-empty": ["error", { "allowEmptyCatch": true }],
+        "no-empty-function": "error",
+        "@angular-eslint/no-empty-lifecycle-method": "error",
+        "no-eval": "warn",
+        "no-extra-semi": "error",
+        "jasmine/no-focused-tests": 2,
+        "jasmine/no-disabled-tests": 2,
+        "no-irregular-whitespace": "error",
+        "no-lonely-if": "error",
+        "no-multi-spaces": ["error", { "ignoreEOLComments": false }],
+        "no-multiple-empty-lines": ["error", { "max": 1 }],
+        "no-restricted-imports": ["error", "rxjs/Rx", "fs"],
+        "no-self-assign": "error",
+        "no-self-compare": "error",
+        "no-setter-return": "error",
+        "no-sparse-arrays": "error",
+        "no-template-curly-in-string": "error",
+        "no-throw-literal": "error",
+        "no-trailing-spaces": "error",
+        "no-unreachable": "error",
+        "no-unreachable-loop": "error",
+        "no-unsafe-optional-chaining": "error",
+        "no-unused-expressions": "error",
+        "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
+        "no-use-before-define": ["error", { "functions": false, "classes": false, "variables": true, "allowNamedExports": false }],
+        "no-whitespace-before-property": ["error"],
+        "object-curly-spacing": ["error", "always"],
+        "prefer-const": "error",
+        "quotes": ["error", "single"],
+        "radix": "off",
+        "require-jsdoc": ["error", {"require": {"FunctionDeclaration": false, "MethodDefinition": true, "ClassDeclaration": false, "ArrowFunctionExpression": false, "FunctionExpression": true}}],
+        "semi": ["error", "always"],
+        "use-isnan": ["error", { "enforceForSwitchCase": true }],
+        "@angular-eslint/use-lifecycle-interface": "error",
+        "@angular-eslint/use-pipe-transform-interface": "error",
+        "valid-typeof": "error"
       }
     },
     {