Skip to content

Fix SQLite adapter with GroupedRecords#216

Merged
yunzheng merged 2 commits intomainfrom
bugfix/sqlite-grouped-record
Feb 27, 2026
Merged

Fix SQLite adapter with GroupedRecords#216
yunzheng merged 2 commits intomainfrom
bugfix/sqlite-grouped-record

Conversation

@yunzheng
Copy link
Member

@yunzheng yunzheng commented Feb 23, 2026

This PR ensures that we don't use record.__slots__ but rather rdict.keys() for creating the sqlite table. Small regression test is included.

Also fixes some other small issues I encountered with GroupedRecord class, mainly by renaming the class variables to dunder variables.

fixes #215

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.23%. Comparing base (1ab6b54) to head (1485a86).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
flow/record/base.py 85.71% 2 Missing ⚠️
flow/record/selector.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   84.20%   84.23%   +0.03%     
==========================================
  Files          35       35              
  Lines        3741     3742       +1     
==========================================
+ Hits         3150     3152       +2     
+ Misses        591      590       -1     
Flag Coverage Δ
unittests 84.23% <84.21%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yunzheng yunzheng requested a review from skepppy February 26, 2026 10:03
Copy link

@skepppy skepppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but looks good to me otherwise

@yunzheng yunzheng requested a review from skepppy February 27, 2026 00:22
@yunzheng yunzheng force-pushed the bugfix/sqlite-grouped-record branch from d90e75b to 1485a86 Compare February 27, 2026 09:33
@yunzheng yunzheng merged commit a30f10d into main Feb 27, 2026
23 checks passed
@yunzheng yunzheng deleted the bugfix/sqlite-grouped-record branch February 27, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grouped records fail for SQLite adapter

2 participants