Skip to content

Fix ipnetwork __contains__ on Python 3.14#194

Merged
yunzheng merged 1 commit intomainfrom
fix-ipnetwork
Oct 23, 2025
Merged

Fix ipnetwork __contains__ on Python 3.14#194
yunzheng merged 1 commit intomainfrom
fix-ipnetwork

Conversation

@yunzheng
Copy link
Member

fixes #193

@yunzheng
Copy link
Member Author

Removes the _is_subnet_of function which was copied because it was not available on older Python versions. Now we can just use IPNetwork.subnet_of as we dropped support for older Python versions.

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.42%. Comparing base (e5a9f56) to head (22676ae).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   83.38%   83.42%   +0.04%     
==========================================
  Files          35       35              
  Lines        3707     3699       -8     
==========================================
- Hits         3091     3086       -5     
+ Misses        616      613       -3     
Flag Coverage Δ
unittests 83.42% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yunzheng yunzheng merged commit b0cb20a into main Oct 23, 2025
23 checks passed
@yunzheng yunzheng deleted the fix-ipnetwork branch October 23, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

net.ipnetwork and net.ipinterface broken on Python 3.14

2 participants