Skip to content

Fix JsonRecordPacker when bytes field is None#180

Merged
yunzheng merged 4 commits intomainfrom
fix/jsonpacker-null-bytes
Aug 12, 2025
Merged

Fix JsonRecordPacker when bytes field is None#180
yunzheng merged 4 commits intomainfrom
fix/jsonpacker-null-bytes

Conversation

@yunzheng
Copy link
Member

Fixes #179

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.98%. Comparing base (820113c) to head (9ecd867).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   82.97%   82.98%           
=======================================
  Files          34       34           
  Lines        3601     3602    +1     
=======================================
+ Hits         2988     2989    +1     
  Misses        613      613           
Flag Coverage Δ
unittests 82.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixes DeprecationWarning: The default datetime adapter is deprecated as of Python 3.12.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems irrelevant?

Copy link
Member Author

@yunzheng yunzheng Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I noticed a deprecation warning during pytest, I was lazy to create a dedicated PR :D

I can still move it to another PR if you think that is better.

@yunzheng yunzheng merged commit e2333a6 into main Aug 12, 2025
25 checks passed
@yunzheng yunzheng deleted the fix/jsonpacker-null-bytes branch August 12, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rdump crashes on fieldtype bytes with the value None

2 participants