Improve rdump exception logging#167
Merged
yunzheng merged 15 commits intofox-it:mainfrom Jun 30, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 82.95% 82.24% -0.72%
==========================================
Files 34 34
Lines 3591 3650 +59
==========================================
+ Hits 2979 3002 +23
- Misses 612 648 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yunzheng
requested changes
Mar 5, 2025
yunzheng
requested changes
Mar 6, 2025
Co-authored-by: Yun Zheng Hu <hu@fox-it.com>
Some exception tracebacks are only shown when using this log level. -v = INFO -vv = DEBUG -vvv = TRACE
Schamper
reviewed
Jun 27, 2025
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
yunzheng
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve rdump's exception logging when using the Elastic adapter.
structlogdependency for colorized log outputwriter.excepthookso no exception occurs while handling exceptions0/1) of rdump should be handled better now.Examples of new compact stacktraces: