Add benchmark for ls_cmd using a ext4 test image of around 1000 files#1622
Open
Add benchmark for ls_cmd using a ext4 test image of around 1000 files#1622
ls_cmd using a ext4 test image of around 1000 files#1622Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
+ Coverage 81.00% 81.06% +0.05%
==========================================
Files 401 402 +1
Lines 35176 35244 +68
==========================================
+ Hits 28495 28571 +76
+ Misses 6681 6673 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Performance Changes
Comparing 
|
yunzheng
force-pushed
the
benchmark-ls-cmd
branch
from
b8d3a1f to
1b6be8a
Compare
Schamper
requested changes
Mar 16, 2026
Schamper
requested changes
Mar 17, 2026
yunzheng
force-pushed
the
benchmark-ls-cmd
branch
3 times, most recently
from
8ab4b02 to
f939c33
Compare
yunzheng
force-pushed
the
benchmark-ls-cmd
branch
from
f939c33 to
9499734
Compare
yunzheng
force-pushed
the
benchmark-ls-cmd
branch
from
9499734 to
9bae921
Compare
Schamper
requested changes
Mar 18, 2026
Comment on lines
+630
to
+631
| The /bin files are all sparse (filled with zeros). | ||
| The files in /etc do contain data. |
Member
There was a problem hiding this comment.
Can you just shortly describe how you created this test image? At some point in the future we might want to put it into a (reproducible) script but for now having a description of the process would be nice already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a benchmark test for the
ls_cmdintarget-shelland a new test fixture providing an ext4 image with around 1000 files for doing the directory listing.The benchmark is in preparation of implementing #1577 and some other related issues, which will contain some refactoring regarding efficiency.
The test image is derived from
debian-live-13.3.0-amd64-standard.isoand only the/bindir and some files from/etcare copied over. The file contents in/binare also all sparse (NULL bytes) so the image compresses well. The test data mainly focuses on what is useful for directory listings, such as filenames, permissions, owner and group.The compressed test image itself is only 100kb.