Conversation
|
hey (: i fixed a few small things that where bothering me. specifically for clsid, im honestly not sure if there was a reason it was how it was before, but i think what i did looks nicer. |
|
Do any of these changes fix bugs you were running into, or are these just code style changes? If the former, would you mind adding unit tests for those scenarios? |
|
i havent really seen these when running, and honestly most of these arent really bugs (i may have to change the name 😅) only one is a real bug and i dont really know how i could test for it, as it was just a list with missing commas. the rest are readability/efficiency upgrades. |
|
Alright, no problem. Can you fix the failing tests before I look further? |
|
i fixed all failed tests, i tried to do it in the least invasive way. hope its good (: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
=======================================
Coverage 81.12% 81.12%
=======================================
Files 401 401
Lines 35091 35093 +2
=======================================
+ Hits 28467 28469 +2
Misses 6624 6624
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
just some minor fixes, with varying importance.