Skip to content

BugFix/small fixes#1592

Open
loaflover wants to merge 15 commits intofox-it:mainfrom
loaflover:feature/small-fixes
Open

BugFix/small fixes#1592
loaflover wants to merge 15 commits intofox-it:mainfrom
loaflover:feature/small-fixes

Conversation

@loaflover
Copy link
Contributor

just some minor fixes, with varying importance.

@loaflover loaflover changed the title Feature/small fixes BugFix/small fixes Mar 2, 2026
@loaflover
Copy link
Contributor Author

hey (:

i fixed a few small things that where bothering me.
fixes range from slightly important to minuscule

specifically for clsid, im honestly not sure if there was a reason it was how it was before, but i think what i did looks nicer.

@Schamper
Copy link
Member

Do any of these changes fix bugs you were running into, or are these just code style changes? If the former, would you mind adding unit tests for those scenarios?

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2026

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing loaflover:feature/small-fixes (e6e0060) with main (b07019c)

Open in CodSpeed

@loaflover
Copy link
Contributor Author

i havent really seen these when running, and honestly most of these arent really bugs (i may have to change the name 😅)

only one is a real bug and i dont really know how i could test for it, as it was just a list with missing commas. the rest are readability/efficiency upgrades.

@Schamper
Copy link
Member

Alright, no problem. Can you fix the failing tests before I look further?

@loaflover
Copy link
Contributor Author

i fixed all failed tests, i tried to do it in the least invasive way.

hope its good (:

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify in the PR description what everything is that you fixed/changed? Useful for creating a changelog later.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.12%. Comparing base (b07019c) to head (e6e0060).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/regf/clsid.py 80.95% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files         401      401           
  Lines       35091    35093    +2     
=======================================
+ Hits        28467    28469    +2     
  Misses       6624     6624           
Flag Coverage Δ
unittests 81.12% <88.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants