Add tests data related to containers (EWF, VDI, VHD, VHDX and VMDK)#1495
Add tests data related to containers (EWF, VDI, VHD, VHDX and VMDK)#1495Schamper merged 27 commits intofox-it:mainfrom
Conversation
|
It look like their is more untested container format, I will add test for them to in this PR (or in dedicated PR, as you wish). |
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
This PR is fine, just rename the PR title. |
william-billaud
changed the title
# Conflicts: # pyproject.toml
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
tests/containers/test_ewf.py
Outdated
| def test_ewf_container_splitted() -> None: | ||
| """Test that EWF containers are properly opened when container is split among multiple files. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Can you do the same everywhere else?
There was a problem hiding this comment.
Sorry, missed this one.
I will write 1 000 times I will not submit review just before leaving work as a reminder.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
==========================================
+ Coverage 80.80% 80.91% +0.10%
==========================================
Files 396 396
Lines 34827 34827
==========================================
+ Hits 28142 28180 +38
+ Misses 6685 6647 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Add tests related to multiple containers format. I do not have any mac to generate tests data for mac related containers format.
Add ~1.5mo of git lfs data.
For each test, I have tried to cover most path/functions available from the container (seek, read etc...)
Bump dissect.evidence dev version.
Related to fox-it/dissect.evidence#47