Skip to content

Use improved SQLite3 to automatically open sidecar WAL files#1454

Merged
Schamper merged 18 commits intofox-it:mainfrom
PimSanders:improvement/use-new-sqlite
Jan 12, 2026
Merged

Use improved SQLite3 to automatically open sidecar WAL files#1454
Schamper merged 18 commits intofox-it:mainfrom
PimSanders:improvement/use-new-sqlite

Conversation

@PimSanders
Copy link
Contributor

@PimSanders PimSanders commented Dec 15, 2025

This PR changes how SQLite3 databases are opened. Initializing the SQLite3 class with a Path object instead of BinaryIO allows for the WAL file to be found automatically. See fox-it/dissect.database#9.

I have found some issues with opening the WAL file of some databases used by Windows, the PR will be a draft for now.

  • dissect/target/loaders/itunes.py
  • dissect/target/plugins/apps/av/mcafee.py
  • dissect/target/plugins/apps/av/sophos.py
  • dissect/target/plugins/apps/browser/chromium.py
  • dissect/target/plugins/apps/browser/firefox.py
  • dissect/target/plugins/apps/container/podman.py
  • dissect/target/plugins/os/unix/esxi/configstore.py
  • dissect/target/plugins/os/unix/linux/debian/proxmox/_os.py
  • dissect/target/plugins/os/windows/activitiescache.py
  • dissect/target/plugins/os/windows/cam.py
  • dissect/target/plugins/os/windows/notifications.py
  • dissect/target/plugins/os/windows/search.py

@PimSanders PimSanders changed the title Use improved SQLite to automatically open sidecar WAL files Use improved SQLite3 to automatically open sidecar WAL files Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.36%. Comparing base (cba43ec) to head (67b12c2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/unix/esxi/configstore.py 5.88% 32 Missing ⚠️
dissect/target/plugins/apps/browser/firefox.py 69.56% 7 Missing ⚠️
dissect/target/loaders/itunes.py 0.00% 1 Missing ⚠️
...target/plugins/os/unix/linux/debian/proxmox/_os.py 96.00% 1 Missing ⚠️
dissect/target/plugins/os/windows/notifications.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   79.90%   80.36%   +0.46%     
==========================================
  Files         392      392              
  Lines       34453    34446       -7     
==========================================
+ Hits        27529    27683     +154     
+ Misses       6924     6763     -161     
Flag Coverage Δ
unittests 80.36% <60.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing PimSanders:improvement/use-new-sqlite (67b12c2) with main (cba43ec)

Summary

✅ 9 untouched benchmarks

@PimSanders
Copy link
Contributor Author

PimSanders commented Dec 15, 2025

Depends on: fox-it/dissect.database#14.

@PimSanders
Copy link
Contributor Author

Depends on: fox-it/dissect.database#15.

@PimSanders PimSanders marked this pull request as ready for review January 7, 2026 14:44
@Schamper
Copy link
Member

Schamper commented Jan 9, 2026

Depends on: fox-it/dissect.database#15.

Can you update the dependency on pyproject.toml to the current .dev version?

PimSanders and others added 3 commits January 10, 2026 22:23
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@PimSanders
Copy link
Contributor Author

I think I have updated the pyproject.toml correctly, could you verify that?

@Schamper
Copy link
Member

I think I have updated the pyproject.toml correctly, could you verify that?

Yep, looks good!

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the linter?

@Schamper Schamper merged commit e0cbfed into fox-it:main Jan 12, 2026
14 of 22 checks passed
Matthijsy pushed a commit to Matthijsy/dissect.target that referenced this pull request Mar 2, 2026
…1454)

Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants