Use improved SQLite3 to automatically open sidecar WAL files#1454
Use improved SQLite3 to automatically open sidecar WAL files#1454Schamper merged 18 commits intofox-it:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
+ Coverage 79.90% 80.36% +0.46%
==========================================
Files 392 392
Lines 34453 34446 -7
==========================================
+ Hits 27529 27683 +154
+ Misses 6924 6763 -161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
|
Depends on: fox-it/dissect.database#14. |
|
Depends on: fox-it/dissect.database#15. |
Can you update the dependency on |
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
|
I think I have updated the |
Yep, looks good! |
…1454) Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
This PR changes how SQLite3 databases are opened. Initializing the SQLite3 class with a
Pathobject instead ofBinaryIOallows for the WAL file to be found automatically. See fox-it/dissect.database#9.I have found some issues with opening the WAL file of some databases used by Windows, the PR will be a draft for now.