Skip to content

Fix record cache test#1441

Merged
Schamper merged 1 commit intomainfrom
fix-record-cache-test
Dec 4, 2025
Merged

Fix record cache test#1441
Schamper merged 1 commit intomainfrom
fix-record-cache-test

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Dec 4, 2025

The test was unnecessarily restrictive towards zstandard filenames. This is not needed. This now showed up because we merged #1380, which removes the zstandard dependency. And because we pinned to an older version of flow.record, it now won't use zstandard files as default.

When we update the flow.record dependency to fox-it/flow.record#198, all will be righteous again.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.00%. Comparing base (52e9f84) to head (a602e23).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1441   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         376      376           
  Lines       33649    33649           
=======================================
  Hits        27256    27256           
  Misses       6393     6393           
Flag Coverage Δ
unittests 81.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #1441 will not alter performance

Comparing fix-record-cache-test (a602e23) with main (52e9f84)

Summary

✅ 9 untouched

@Schamper Schamper merged commit 58f6c0c into main Dec 4, 2025
16 of 22 checks passed
@Schamper Schamper deleted the fix-record-cache-test branch December 4, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants