Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
+ Coverage 80.94% 81.02% +0.08%
==========================================
Files 376 376
Lines 33544 33593 +49
==========================================
+ Hits 27153 27220 +67
+ Misses 6391 6373 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1389 will not alter performanceComparing Summary
|
twiggler
left a comment
There was a problem hiding this comment.
Don't forget about APFS
twiggler
left a comment
There was a problem hiding this comment.
I think the windows unit tests are failing
|
Am I correct to assume this PR should or does not introduce breaking changes for existing filesystem implementations? I see the |
If you implemented your own
Any code that uses the |
Related to #649, but I don't want to close that with this PR since there's still quite a lot of work left to do.
This is my initial effort into adding a
DirEntryclass that accompaniesFilesystemEntry. With this, aFilesystemEntrycould be seen more akin to an "inode", andDirEntryis, obviously, a "dirent". The function signature of.scandir()changes with this PR.Not all possible improvements are immediately implemented with this PR, I want to do that incrementally. For example,
VirtualFilesystemshould get a major refactor, which means a ton of other "filesystems" will too. There's also a ton of separate improvements to be made for each filesystem, as most implementations don't currently have aDirEntryconcept of their own (with the exception of VMFS and APFS, and NTFS with fox-it/dissect.ntfs#48, which this PR depends on).Also the mentioned possibility of "flags" on directory entries in #649 is not implemented yet (e.g. "deleted").