Skip to content

Prevent OS modules of being hidden during docs-build#1297

Merged
Miauwkeru merged 4 commits intomainfrom
enable-os-checks
Mar 19, 2026
Merged

Prevent OS modules of being hidden during docs-build#1297
Miauwkeru merged 4 commits intomainfrom
enable-os-checks

Conversation

@Miauwkeru
Copy link
Contributor

  • Stop skipping OS modules during docs-build
  • Add docstring to ConfigNode and FortiOSConfig

Autoapi made it use the docstring of its parent `dict`. This docstring
contains leading spaces that sphinx doesn't like. So I added some
docstrings
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (6117402) to head (4c3e021).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1297   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         402      402           
  Lines       35244    35244           
=======================================
  Hits        28571    28571           
  Misses       6673     6673           
Flag Coverage Δ
unittests 81.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing enable-os-checks (4c3e021) with main (6117402)

Open in CodSpeed

@Schamper
Copy link
Member

What's the status of this?

@Miauwkeru
Copy link
Contributor Author

What's the status of this?

It needs a review, but fell through the cracks when being busy with other stuff

@Schamper
Copy link
Member

I don't think the title accurately reflects the changes? Nothing is "enabled", it's rather a "prevent OS plugins from being hidden".

@Miauwkeru Miauwkeru changed the title Enable OS modules during docs-build Prevent OS modules of being hidden during docs-build Mar 19, 2026
@Miauwkeru Miauwkeru merged commit 4ba8f14 into main Mar 19, 2026
39 of 45 checks passed
@Miauwkeru Miauwkeru deleted the enable-os-checks branch March 19, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants