Skip to content

Add VMware Workstation inventory parser function#1274

Merged
Schamper merged 9 commits intofox-it:mainfrom
JSCU-CNI:vmware-workstation-vm-inventory
Oct 20, 2025
Merged

Add VMware Workstation inventory parser function#1274
Schamper merged 9 commits intofox-it:mainfrom
JSCU-CNI:vmware-workstation-vm-inventory

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Aug 6, 2025

Basically exposes what the child plugin already parsed as a plugin function. Created with #1133 in mind.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not looked in-depth yet, but can we replace the "parsing" of the file in list_children with this?

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Sep 9, 2025

but can we replace the "parsing" of the file in list_children with this?

Yes that is the general idea, once #1133 is merged.

@JSCU-CNI JSCU-CNI requested a review from Schamper October 13, 2025 11:13
@JSCU-CNI JSCU-CNI requested a review from Schamper October 15, 2025 09:11
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
@JSCU-CNI JSCU-CNI requested a review from Schamper October 20, 2025 08:03
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.73%. Comparing base (083729a) to head (28105d7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../plugins/apps/virtualization/vmware_workstation.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1274   +/-   ##
=======================================
  Coverage   80.72%   80.73%           
=======================================
  Files         376      376           
  Lines       33382    33396   +14     
=======================================
+ Hits        26949    26963   +14     
  Misses       6433     6433           
Flag Coverage Δ
unittests 80.73% <97.56%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #1274 will not alter performance

Comparing JSCU-CNI:vmware-workstation-vm-inventory (28105d7) with main (083729a)

Summary

✅ 9 untouched

@Schamper Schamper merged commit c5427a3 into fox-it:main Oct 20, 2025
20 of 22 checks passed
@JSCU-CNI JSCU-CNI deleted the vmware-workstation-vm-inventory branch October 20, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants