Add VMware Workstation inventory parser function#1274
Merged
Schamper merged 9 commits intofox-it:mainfrom Oct 20, 2025
Merged
Conversation
Schamper
requested changes
Aug 6, 2025
Member
Schamper
left a comment
There was a problem hiding this comment.
Have not looked in-depth yet, but can we replace the "parsing" of the file in list_children with this?
Contributor
Author
Yes that is the general idea, once #1133 is merged. |
Schamper
requested changes
Oct 14, 2025
dissect/target/plugins/apps/virtualization/vmware_workstation.py
Outdated
Show resolved
Hide resolved
dissect/target/plugins/apps/virtualization/vmware_workstation.py
Outdated
Show resolved
Hide resolved
Schamper
requested changes
Oct 14, 2025
dissect/target/plugins/apps/virtualization/vmware_workstation.py
Outdated
Show resolved
Hide resolved
Schamper
requested changes
Oct 17, 2025
dissect/target/plugins/apps/virtualization/vmware_workstation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
=======================================
Coverage 80.72% 80.73%
=======================================
Files 376 376
Lines 33382 33396 +14
=======================================
+ Hits 26949 26963 +14
Misses 6433 6433
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Schamper
approved these changes
Oct 20, 2025
CodSpeed Performance ReportMerging #1274 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically exposes what the child plugin already parsed as a plugin function. Created with #1133 in mind.