-
Notifications
You must be signed in to change notification settings - Fork 89
Extend child-support #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Extend child-support #1133
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| from dissect.target.exceptions import UnsupportedPluginError | ||
| from dissect.target.helpers.record import ChildTargetRecord | ||
| from dissect.target.plugin import ChildTargetPlugin | ||
|
|
||
| if TYPE_CHECKING: | ||
| from collections.abc import Iterator | ||
|
|
||
| from dissect.target import Target | ||
|
|
||
|
|
||
| class LimaChildTargetPlugin(ChildTargetPlugin): | ||
Schamper marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| """Child target plugin that yields Lima VMs. | ||
|
|
||
| Lima (Linux Machines) is a Linux VM or container runtime for macOS and Linux. | ||
|
|
||
| References: | ||
| - https://github.com/lima-vm/lima | ||
| """ | ||
|
|
||
| __type__ = "lima" | ||
|
|
||
| def __init__(self, target: Target): | ||
| super().__init__(target) | ||
| self.paths = [] | ||
| for user in self.target.user_details.all_with_home(): | ||
| # check .lima folder in ~/ | ||
| if (path := user.home_path.joinpath(".lima")).exists(): | ||
| self.paths.append(path) | ||
| # check .lima folder in ~/.config/ | ||
| if (path := user.home_path.joinpath(".config", "lima")).exists(): | ||
| self.paths.append(path) | ||
|
|
||
| def check_compatible(self) -> None: | ||
| if not self.paths: | ||
| raise UnsupportedPluginError("No Lima configurations found") | ||
|
|
||
| def list_children(self) -> Iterator[ChildTargetRecord]: | ||
| for path in self.paths: | ||
| for instance in path.iterdir(): | ||
| if instance.name.startswith((".", "_")) or not instance.is_dir(): | ||
| continue | ||
|
|
||
| yield ChildTargetRecord( | ||
| type=self.__type__, | ||
| name=instance.name, | ||
| path=instance.joinpath("diffdisk"), | ||
| _target=self.target, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JSCU-CNI I changed this from
namestoname, seemed to be an oversight in naming since it's seemingly always a singular name, but let me know if I'm overlooking anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally called
namessince that is how Docker, Podman (and iirc other) container platforms tag their container name (see for example output ofdocker ps -aorpodman ps -a).https://docs.docker.com/reference/cli/docker/container/ls/#format
https://docs.podman.io/en/v5.0.2/markdown/podman-ps.1.html#format-format
From the dissect perspective I guess it makes sense to make the field singular if it is not a
string[]field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that, but I think that's silly 😄. In the linked example of Docker there's a
redis,webapp/dbcontainer names though, do you know how that occurs, and if we support that already?