Skip to content

Add support for using multiple checksum algorithms in AsdfWriter#49

Open
Miauwkeru wants to merge 1 commit intomainfrom
asdf-multiple-signature-support
Open

Add support for using multiple checksum algorithms in AsdfWriter#49
Miauwkeru wants to merge 1 commit intomainfrom
asdf-multiple-signature-support

Conversation

@Miauwkeru
Copy link
Contributor

This changed the FILE_FLAGS a little bit to use part of that
file space for an enum of CHECKSUMS instead of using flags.

Adjusted asdf/verify.py to use the new signatures and added a test to
verify that it functions as inteded with test_asdf_verify.py.
This also tests any additional item that gets added to CHECKSUM_MAPPING

This changed the FILE_FLAGS a little bit to use part of that
file space for an enum of CHECKSUMS instead of using flags.

Adjusted `asdf/verify.py` to use the new signatures and added a test to
verify that it functions as inteded with `test_asdf_verify.py`.
This also tests any additional item that gets added to CHECKSUM_MAPPING
@Miauwkeru Miauwkeru requested a review from Schamper February 2, 2026 15:41
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.98%. Comparing base (596dba4) to head (ec58959).

Files with missing lines Patch % Lines
dissect/evidence/asdf/asdf.py 83.33% 1 Missing ⚠️
dissect/evidence/tools/asdf/verify.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   71.44%   76.98%   +5.54%     
==========================================
  Files          23       23              
  Lines        1387     1395       +8     
==========================================
+ Hits          991     1074      +83     
+ Misses        396      321      -75     
Flag Coverage Δ
unittests 76.98% <84.61%> (+5.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant