Add support for using multiple checksum algorithms in AsdfWriter#49
Open
Add support for using multiple checksum algorithms in AsdfWriter#49
Conversation
This changed the FILE_FLAGS a little bit to use part of that file space for an enum of CHECKSUMS instead of using flags. Adjusted `asdf/verify.py` to use the new signatures and added a test to verify that it functions as inteded with `test_asdf_verify.py`. This also tests any additional item that gets added to CHECKSUM_MAPPING
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 71.44% 76.98% +5.54%
==========================================
Files 23 23
Lines 1387 1395 +8
==========================================
+ Hits 991 1074 +83
+ Misses 396 321 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changed the FILE_FLAGS a little bit to use part of that
file space for an enum of CHECKSUMS instead of using flags.
Adjusted
asdf/verify.pyto use the new signatures and added a test toverify that it functions as inteded with
test_asdf_verify.py.This also tests any additional item that gets added to CHECKSUM_MAPPING