Add AD1 and ADCRYPT implementations#39
Conversation
Schamper
left a comment
There was a problem hiding this comment.
I still haven't looked in much detail at the actual parsing, but these comments are quite big again. Let me know if I can be of any help resolving them.
|
I've made some changes, let me know if you agree. |
89e5f6c to
08365f4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 63.17% 71.44% +8.27%
==========================================
Files 11 23 +12
Lines 1013 1387 +374
==========================================
+ Hits 640 991 +351
- Misses 373 396 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you for the applied changes, especially the ADCRYPT and stream implementations. Will take a look at the companion PR in dissect.target to make |
This PR fixes the AD1 implementation and adds support for rudimentary ADCRYPT decryption using the cli tool
adecrypt(#37, #38). Also restructured the project and tests a bit.